Make status message default the empty byte sequence#600
Conversation
|
Tests: web-platform-tests/wpt#7274 (note that this is an issue, not actual tests, due to lack of HTTP/2 support). |
ca928c2 to
89f2501
Compare
|
@jakearchibald not sure who else to ask for review, but Chrome and Safari already ship this. |
|
It seems I should investigate #664 first. In particular, what is the status message for synthetic redirects. |
|
Note that the default for |
|
I need to file a bug against Chrome, Edge, and Firefox for changing |
|
Additional tests are web-platform-tests/wpt#10442. |
jakearchibald
left a comment
There was a problem hiding this comment.
Comments are just nits.
fetch.bs
Outdated
| otherwise it is the empty byte sequence. | ||
|
|
||
| <p class=note>This does not have a default value of `<code>OK</code>` as otherwise all HTTP/2 | ||
| <a for=/>responses</a> would have that value. |
There was a problem hiding this comment.
Maybe make it clear that HTTP/2 doesn't support status messages. Something like: "HTTP/2 doesn't support status messages, so this property will be an empty byte sequence for all responses from an HTTP/2 connection"
| `<code>text/html;charset=utf-8</code>`, <a for=response>body</a> is the empty byte sequence, and | ||
| <a for=response>HTTPS state</a> is <var>request</var>'s <a for=request>client</a>'s | ||
| <a for="environment settings object">HTTPS state</a> if <var>request</var>'s | ||
| <a for=request>client</a> is non-null. |
There was a problem hiding this comment.
Given the number of properties, dl/ul would be clearer.
| <li><p>Return a <a for=/>response</a> whose <a for=response>status message</a> is | ||
| `<code>OK</code>`, whose <a for=response>header list</a> consist of a single <a for=/>header</a> | ||
| whose <a for=header>name</a> is `<code>Content-Type</code>` and <a for=header>value</a> is | ||
| <var>dataURLStruct</var>'s <a for="data: URL struct">MIME type</a>, |
There was a problem hiding this comment.
I know it isn't something you changed in this PR, but there's a repetition of "whose" here which is inconsistent with the similar lines above.
Again, dl/ul could be useful here, especially when it comes to the header list.
…ions, a=testonly Automatic update from web-platform-testsFetch: expand Response.redirect() assertions Needed for whatwg/fetch#664 and whatwg/fetch#600. -- wpt-commits: 507af0c03617714bfd4134c54da4d534906ee52b wpt-pr: 10442
…ions, a=testonly Automatic update from web-platform-testsFetch: expand Response.redirect() assertions Needed for whatwg/fetch#664 and whatwg/fetch#600. -- wpt-commits: 507af0c03617714bfd4134c54da4d534906ee52b wpt-pr: 10442 UltraBlame original commit: d9ac927c0b85220a5183f9e22f3c35affd531a8d
…ions, a=testonly Automatic update from web-platform-testsFetch: expand Response.redirect() assertions Needed for whatwg/fetch#664 and whatwg/fetch#600. -- wpt-commits: 507af0c03617714bfd4134c54da4d534906ee52b wpt-pr: 10442 UltraBlame original commit: d9ac927c0b85220a5183f9e22f3c35affd531a8d
…ions, a=testonly Automatic update from web-platform-testsFetch: expand Response.redirect() assertions Needed for whatwg/fetch#664 and whatwg/fetch#600. -- wpt-commits: 507af0c03617714bfd4134c54da4d534906ee52b wpt-pr: 10442 UltraBlame original commit: d9ac927c0b85220a5183f9e22f3c35affd531a8d
…ions, a=testonly Automatic update from web-platform-testsFetch: expand Response.redirect() assertions Needed for whatwg/fetch#664 and whatwg/fetch#600. -- wpt-commits: 507af0c03617714bfd4134c54da4d534906ee52b wpt-pr: 10442
Fixes #599.
Preview | Diff