Fetch: expand Response.redirect() assertions#10442
Merged
Conversation
jakearchibald
requested changes
Apr 23, 2018
Contributor
jakearchibald
left a comment
There was a problem hiding this comment.
Also test the new Response() case? Eg https://github.com/w3c/web-platform-tests/blob/master/fetch/api/response/response-init-001.html
Member
Author
|
That is explicitly not changed here, see whatwg/fetch#698. |
annevk
added a commit
to whatwg/fetch
that referenced
this pull request
Apr 24, 2018
HTTP/2 does not have a status message (reason phrase) and giving all of HTTP/2's responses `OK` as status message would not be ideal. Therefore this change to the empty byte sequence. As a side effect, that's also a better default for Response.redirect(). Tests: web-platform-tests/wpt#7274 (issue due to lack of HTTP/2 support) and web-platform-tests/wpt#10442 (for Response.redirect()). Fixes #599 and fixes #664. Potential follow-up: #698.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for whatwg/fetch#664 and whatwg/fetch#600.
Safari already passes these. Chrome and Firefox have
statusTextreturningOK.