fix: make extractComments API more consistent#129
Merged
alexander-akait merged 1 commit intomasterfrom Sep 2, 2019
Merged
Conversation
BREAKING CHANGE: using the `extractComments.condition` option with `true` value extract only `some` comments
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 98.58% 98.61% +0.02%
==========================================
Files 5 5
Lines 283 288 +5
Branches 113 117 +4
==========================================
+ Hits 279 284 +5
Misses 4 4
Continue to review full report at Codecov.
|
haoqunjiang
added a commit
to haoqunjiang/vue-cli
that referenced
this pull request
Oct 11, 2019
BREAKING CHANGE: The only real breaking change is webpack/terser-webpack-plugin#129, which is not likely to affect normal users. The rest are default option values changes, which are already covered in the default provided `terserOptions` of Vue CLI. Note that here we choose to disable `extractComments` by default, as I don't see enough data showing such license comments taking too much space. The extra LICENSE file may also be confusing to some users.
9 tasks
haoqunjiang
added a commit
to vuejs/vue-cli
that referenced
this pull request
Oct 11, 2019
BREAKING CHANGE: The only real breaking change is webpack/terser-webpack-plugin#129, which is not likely to affect normal users. The rest are default option values changes, which are already covered in the default provided `terserOptions` of Vue CLI. Note that here we choose to disable `extractComments` by default, as I don't see enough data showing such license comments taking too much space. The extra LICENSE file may also be confusing to some users.
ZanderOlidan
pushed a commit
to ZanderOlidan/vue-cli-service-chalkfix
that referenced
this pull request
Feb 5, 2024
BREAKING CHANGE: The only real breaking change is webpack/terser-webpack-plugin#129, which is not likely to affect normal users. The rest are default option values changes, which are already covered in the default provided `terserOptions` of Vue CLI. Note that here we choose to disable `extractComments` by default, as I don't see enough data showing such license comments taking too much space. The extra LICENSE file may also be confusing to some users.
ZanderOlidan
pushed a commit
to ZanderOlidan/vue-cli-service-chalkfix
that referenced
this pull request
Feb 5, 2024
BREAKING CHANGE: The only real breaking change is webpack/terser-webpack-plugin#129, which is not likely to affect normal users. The rest are default option values changes, which are already covered in the default provided `terserOptions` of Vue CLI. Note that here we choose to disable `extractComments` by default, as I don't see enough data showing such license comments taking too much space. The extra LICENSE file may also be confusing to some users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #20
Breaking Changes
Yes
BREAKING CHANGE: using the
extractComments.conditionoption withtruevalue extract onlysomecommentsAdditional Info
No