Skip to content

Make extractComments API more consistent #20

@bryanph

Description

@bryanph
  • terser-webpack-plugin Version: 1.1.0

Expected Behavior / Situation

passing

new TerserPlugin({
  extractComments: true
})

should behave the same as

new TerserPlugin({
  extractComments: {
    condition: true
  }
})

Actual Behavior / Situation

The first case makes condition equal some and the second case makes condition equal all

Modification Proposal

Modify the second case to also equal some (or vice-versa)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions