Skip to content

fix: use dns.lookup instead of dns.resolveX#14290

Merged
christian-bromann merged 1 commit intowebdriverio:cb/bidi-testsfrom
mato533:ta/bidi-test
Mar 17, 2025
Merged

fix: use dns.lookup instead of dns.resolveX#14290
christian-bromann merged 1 commit intowebdriverio:cb/bidi-testsfrom
mato533:ta/bidi-test

Conversation

@mato533
Copy link
Member

@mato533 mato533 commented Mar 17, 2025

Proposed changes

This Pull request is for #14272

This PR is proposed following changes and related updates for unit test (not changed E2E test).

  • use use dns.lookup instead of dns.resolveX
    dns.resolveX is not considering into OS local resolution(e.g. /etc/hosts). (Only resolve with DNS)
    This point causes the error when use the hostname with localhost of the URL.
    Generally speaking the localhost could no be resolved by DNS.(e.g. Google DNS 8.8.8.8 will be error when resolving the localhost)
  • Update the cleanup logic for unused web sockets.
    When ws.readyState is CONNECTING, the ws.terminate() will cause the error using process.nextTick.
    So, in the CONNECTING state, the socket is now terminated after it has entered the OPEN state.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 17, 2025

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14290

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14290

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14290

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14290

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14290

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14290

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14290

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14290

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14290

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14290

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14290

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14290

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14290

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14290

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14290

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14290

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14290

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14290

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14290

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14290

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14290

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14290

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14290

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14290

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14290

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14290

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14290

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14290

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14290

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14290

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14290

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14290

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14290

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14290

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14290

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14290

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14290

commit: ca2cfbf

@mato533 mato533 mentioned this pull request Mar 17, 2025
Merged
13 tasks
christian-bromann
christian-bromann approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks ❤️

@christian-bromann christian-bromann merged commit 0401de2 into webdriverio:cb/bidi-tests Mar 17, 2025
43 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Mar 17, 2025

Hey mato533 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
⚠️ You seemed to have committed using an email address ending up with @users.noreply.github.com, if you don't receive the email please feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

christian-bromann added a commit that referenced this pull request Mar 17, 2025
@christian-bromann @mato533
chore(webdriver): add unit tests for DNS patch (#14272)
f56e47b 
* chore(webdriver): add unit tests for DNS patch

* make it work

* improve implementation

* try catch WebSocket creation

* fix tests

* fix: update lookup (#14290)

* return early

---------

Co-authored-by: mato533 <35281743+mato533@users.noreply.github.com>
@mato533 mato533 deleted the ta/bidi-test branch March 18, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $50 💸

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mato533 @wdio-bot @christian-bromann