chore(webdriver): add unit tests for DNS patch#14272
Merged
christian-bromann merged 7 commits intomainfrom Mar 17, 2025
Merged
Conversation
Merged
13 tasks
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/browser-runner
@wdio/browserstack-service
@wdio/appium-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
4ddc3ec to
5a54d60
Compare
mykola-mokhnach
approved these changes
Mar 14, 2025
Contributor
|
It looks like some e2e tests need to be updated |
13 tasks
Member
|
Sorry to jump in. We have modified some of the code where this PR is concerned to ensure that the E2E test is successful. |
Member
Author
|
Thanks @mato533 for helping push this over the goal line 🙏 |
DudaGod
reviewed
Mar 20, 2025
| const websockets: WebSocket[] = candidateUrls.map((candidateUrl) => { | ||
| log.debug(`Attempt to connect to webSocketUrl ${candidateUrl}`) | ||
| try { | ||
| const ws = new WebSocket(candidateUrl) |
Contributor
There was a problem hiding this comment.
Can we send options here as second argument in order to be able to send headers when connect to browser using ws? These options are already passed to connectWebsocket method
Member
|
@DudaGod @christian-bromann |
13 tasks
Member
Author
|
Sounds good to me, merged #14303 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds unit tests for #14259. It also moves most of the added logic into a separate file as it is Node.js related and we want to keep basic implementations unrelated to the environment where it is executed in.
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
@mykola-mokhnach please review
Reviewers: @webdriverio/project-committers