Skip to content

fix: Try to resolve ip addresses if no BiDi connection to the host could be established#14259

Merged
christian-bromann merged 9 commits intowebdriverio:mainfrom
mykola-mokhnach:bidi_conn_ip
Mar 12, 2025
Merged

fix: Try to resolve ip addresses if no BiDi connection to the host could be established#14259
christian-bromann merged 9 commits intowebdriverio:mainfrom
mykola-mokhnach:bidi_conn_ip

Conversation

@mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Mar 10, 2025

Proposed changes

Addresses #14039

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

mykola-mokhnach
mykola-mokhnach commented Mar 10, 2025
View reviewed changes
erwinheitzman
erwinheitzman reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution!

Looking great, I've added some feedback and questions.

christian-bromann
christian-bromann reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR. Added more comments.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 11, 2025

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14259

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14259

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14259

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14259

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14259

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14259

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14259

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14259

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14259

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14259

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14259

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14259

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14259

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14259

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14259

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14259

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14259

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14259

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14259

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14259

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14259

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14259

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14259

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14259

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14259

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14259

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14259

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14259

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14259

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14259

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14259

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14259

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14259

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14259

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14259

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14259

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14259

commit: 7351653

@christian-bromann
Copy link
Member

christian-bromann commented Mar 11, 2025

@mykola-mokhnach let me know if you need any help with the unit tests.

@mykola-mokhnach
Copy link
Contributor Author

mykola-mokhnach commented Mar 11, 2025

@christian-bromann Could you please help with unit test updates?

christian-bromann
christian-bromann approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM 👍

I will push a test after merge.

@christian-bromann christian-bromann merged commit 795d2d2 into webdriverio:main Mar 12, 2025
3 checks passed
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 12, 2025
@christian-bromann christian-bromann mentioned this pull request Mar 12, 2025
Merged
13 tasks
@christian-bromann
Copy link
Member

christian-bromann commented Mar 12, 2025

@mykola-mokhnach mind reviewing #14272 ?

@mato533 mato533 mentioned this pull request Mar 13, 2025
Merged
13 tasks
@nicolasbouffard nicolasbouffard mentioned this pull request Mar 24, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwinheitzman erwinheitzman erwinheitzman left review comments

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mykola-mokhnach @christian-bromann @erwinheitzman