Skip to content

(webdriverio): polish intercepted errors#12534

Merged
christian-bromann merged 5 commits intowebdriverio:v8from
erwinheitzman:polish/polish-intercepted-errors-v8-backport
Mar 22, 2024
Merged

(webdriverio): polish intercepted errors#12534
christian-bromann merged 5 commits intowebdriverio:v8from
erwinheitzman:polish/polish-intercepted-errors-v8-backport

Conversation

@erwinheitzman
Copy link
Copy Markdown
Member

@erwinheitzman erwinheitzman commented Mar 20, 2024

Proposed changes

Backport of #12533

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@erwinheitzman erwinheitzman mentioned this pull request Mar 20, 2024
Merged
13 tasks
@erwinheitzman erwinheitzman marked this pull request as ready for review March 20, 2024 14:01
@erwinheitzman erwinheitzman added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 20, 2024
@wswebcreation wswebcreation self-requested a review March 20, 2024 14:24
wswebcreation
wswebcreation requested changes Mar 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you also add UTs for this?

christian-bromann
christian-bromann approved these changes Mar 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Mar 21, 2024

🤔 seems like the test is failing in CI.

@erwinheitzman
Copy link
Copy Markdown
Member Author

erwinheitzman commented Mar 22, 2024

I believe that the current failing tests are due to something else right?

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Mar 22, 2024

I believe that the current failing tests are due to something else right?

Correct, some of the e2e tests that we don't have anymore in main are flaky, we can continue.

christian-bromann
christian-bromann approved these changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 705d253 into webdriverio:v8 Mar 22, 2024
JohnJoser3 pushed a commit to JohnJoser3/webdriverio-browserstack-docs that referenced this pull request May 3, 2024
@erwinheitzman @JohnJoser3
(webdriverio): polish intercepted errors (webdriverio#12534)
d429887 
* (webdriverio): polish intercepted errors

* (wdio-browser-runner): add e2e test

* polish: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wswebcreation wswebcreation wswebcreation requested changes

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erwinheitzman @christian-bromann @wswebcreation