Skip to content

(webdriverio): polish intercepted errors#12533

Merged
erwinheitzman merged 6 commits intowebdriverio:mainfrom
erwinheitzman:polish/polish-intercepted-errors
Mar 22, 2024
Merged

(webdriverio): polish intercepted errors#12533
erwinheitzman merged 6 commits intowebdriverio:mainfrom
erwinheitzman:polish/polish-intercepted-errors

Conversation

@erwinheitzman
Copy link
Copy Markdown
Member

@erwinheitzman erwinheitzman commented Mar 20, 2024

Proposed changes

Resolves #8507

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

Reviewers: @webdriverio/project-committers

@erwinheitzman erwinheitzman marked this pull request as ready for review March 20, 2024 14:01
@erwinheitzman erwinheitzman added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 20, 2024
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

As @wswebcreation mentioned in the other PR, would be great to have a test for this. I recommend using one of the browser tests in /e2e/browser for this as you can just generate a random HTML structure to run tests on. Happy to help!

Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍


return result
} catch (err: any) {
if (err.name === 'element not interactable') {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in Safari the error name is different which is why the CI test is failing, mind giving it a try with Safari?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the stacktrace from another error which had the session info. Since I added the tests without having the fix from the other PR in this I made a guess and seems like this doesn't have the session info when running Safari so I it is easily solved 👍
Will fix it and when green merge it

Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the CI failure.

@erwinheitzman erwinheitzman merged commit 8d53ef8 into webdriverio:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: no lines or helpful info displayed for "element not interactable"

2 participants