[testharness.js] introduce assert_precondition#19993
Merged
Conversation
4fdb848 to
3e9e171
Compare
foolip
commented
Nov 2, 2019
Member
Author
|
https://wpt.fyi/results/vibration/invalid-values.html?diff&filter=ADC&run_id=344870003&run_id=344860005 shows that this had the intended effect for one test at least. |
392bfd3 to
fa5e45b
Compare
foolip
commented
Nov 6, 2019
Member
Author
foolip
left a comment
There was a problem hiding this comment.
Bringing a detail to the attention of RFC reviewers coming from web-platform-tests/rfcs#16 (comment).
|
|
||
| if (global_scope.addEventListener) { | ||
| var error_handler = function(message, stack) { | ||
| var error_handler = function(error, message, stack) { |
Member
Author
There was a problem hiding this comment.
There might be reasonable disagreement to be had about this one, whether an unwrapped precondition_failed should be an error or not. And also whether it really makes sense for allow_uncaught_exception to allow failing asserts as is currently the case.
| if (tests.tests.length === 0) { | ||
| tests.status.status = tests.status.ERROR; | ||
| tests.status.message = "done() was called without first defining any tests"; | ||
| if (tests.status.status === null) { |
Member
Author
There was a problem hiding this comment.
This extra check is a workaround for #20036 (comment) but it might change, I'll use whatever change @jugglinmike lands to fix it.
lukebjerring
reviewed
Nov 6, 2019
foolip
commented
Nov 6, 2019
jgraham
approved these changes
Nov 6, 2019
c223650 to
c03ce9b
Compare
foolip
commented
Nov 6, 2019
Member
Author
|
With #20168 now merged I'll rebase this. |
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of #16689. Fixes #19844.
This demonstrates the use of `assert_precondition` for subtests.
d9f0280 to
f378614
Compare
Member
Author
|
Alright, given no concerns voices about the behavior of a bare |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 15, 2019
Address upstream WPT test harness changes web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 15, 2019
Address upstream WPT test harness changes web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 15, 2019
Address upstream WPT test harness changes web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 15, 2019
Address upstream WPT test harness changes web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 16, 2019
Address upstream WPT test harness changes web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 16, 2019
Address upstream WPT test harness changes web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 16, 2019
Address upstream WPT test harness changes web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status:
https://bugzilla.mozilla.org/show_bug.cgi?id=1589056
Implements web-platform-tests/rfcs#16.
Includes parts of #16689.
Fixes #19844.