Skip to content

Address upstream WPT test harness changes#24732

Merged
bors-servo merged 4 commits intoservo:masterfrom
jdm:wptfixes
Nov 16, 2019
Merged

Address upstream WPT test harness changes#24732
bors-servo merged 4 commits intoservo:masterfrom
jdm:wptfixes

Conversation

@jdm
Copy link
Member

@jdm jdm commented Nov 13, 2019

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 13, 2019
asajeffrey
asajeffrey approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@asajeffrey asajeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdm
Copy link
Member Author

jdm commented Nov 14, 2019

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2019

📌 Commit bcaf43d has been approved by asajeffrey

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 14, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit bcaf43d with merge 3ccc7c6...

bors-servo pushed a commit that referenced this pull request Nov 15, 2019
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
3ccc7c6 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 15, 2019
@CYBAI
Copy link
Member

CYBAI commented Nov 15, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit bcaf43d with merge c0f30fc...

bors-servo pushed a commit that referenced this pull request Nov 15, 2019
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
c0f30fc 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 15, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 15, 2019
@CYBAI
Copy link
Member

CYBAI commented Nov 15, 2019 

{
    "status": "FAIL", 
    "group": "default", 
    "message": "", 
    "stack": "step@http://web-platform.test:8000/_mozilla/mozilla/window_requestAnimationFrame2.html:18:17\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1931:25\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1956:35\n", 
    "subtest": "Test throwing an error inside requestAnimationFrame callback", 
    "test": "/_mozilla/mozilla/window_requestAnimationFrame2.html", 
    "line": 196908, 
    "action": "test_result", 
    "expected": "PASS"
}

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 15, 2019
@jdm
Copy link
Member Author

jdm commented Nov 15, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

📌 Commit 010b8a6 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 15, 2019
@jdm
Copy link
Member Author

jdm commented Nov 16, 2019

@bors-servo retry

bors-servo pushed a commit that referenced this pull request Nov 16, 2019
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
67777eb 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 4041caf with merge 67777eb...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 16, 2019
@jdm
Copy link
Member Author

jdm commented Nov 16, 2019

@bors-servo treeclosed=10
mac3 is broken and ruining everything (#24755)

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 16, 2019
@SimonSapin
Copy link
Member

SimonSapin commented Nov 16, 2019

mac3 should be out of the pool now servo/taskcluster-config#5 (comment)

@bors-servo treeclosed-

@jdm
Copy link
Member Author

jdm commented Nov 16, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

💣 Failed to start rebuilding: 405 Not Allowed

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 4041caf with merge c1c9ab6...

bors-servo pushed a commit that referenced this pull request Nov 16, 2019
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
c1c9ab6 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 16, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 16, 2019
@jdm
Copy link
Member Author

jdm commented Nov 16, 2019

@bors-servo retry
#13480

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 4041caf with merge 04119ed...

bors-servo pushed a commit that referenced this pull request Nov 16, 2019
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
04119ed 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 16, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing 04119ed to master...

@bors-servo bors-servo merged commit 4041caf into servo:master Nov 16, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@asajeffrey asajeffrey asajeffrey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@asajeffrey asajeffrey

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jdm @bors-servo @CYBAI @SimonSapin @asajeffrey @highfive