Add tests for clicking the child of a button element#14426
Merged
tkent-google merged 1 commit intoDec 10, 2018
Conversation
tkent-google
approved these changes
Dec 10, 2018
Member
|
Never mind, I missed the "event’s bubbles attribute is true" check in the DOM Standard. My bad. It would still be good to file implementation bugs though to make Chrome and Safari aware of this. |
domenic
pushed a commit
to jsdom/jsdom
that referenced
this pull request
Dec 11, 2018
This adds steps regarding activation behavior from the 'To dispatch an event...' algorithm located at https://dom.spec.whatwg.org/#concept-event-dispatch. It also renames the existing hooks to match the names used in the specification. Fixes #2449 and fixes #2367. This commit also includes a web platform tests roll, as the tests for this change landed in web-platform-tests/wpt#14426.
Member
Author
|
@annevk Okay, I've filed the following bugs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tests for jsdom/jsdom#2450.
The last test passes in Firefox but fails in Chrome and Safari. I think the test is correct based on the Dispatch an event algorithm, in that non-bubbling events should not cause the activation behavior of parents to run.