Run activation behavior hooks from the event dispatch algorithm #2450
Merged
Conversation
TimothyGu
reviewed
Dec 8, 2018
09ec5b7 to
17b3bbb
Compare
Member
Author
|
Tests submitted in web-platform-tests/wpt#14426. |
This was referenced Dec 9, 2018
Closed
This adds steps regarding activation behavior from the 'To dispatch an event...' algorithm located at https://dom.spec.whatwg.org/#concept-event-dispatch. I've also renamed the existing hooks to match the names used in the specification. This fixes jsdom#2449.
17b3bbb to
b5c6d56
Compare
Member
Author
|
Updated to add |
Member
|
Nice work. Let's wait to merge this until a WPT roll though, just out of principle :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds steps regarding activation behavior from the Dispatch an event algorithm, replacing older code where the activation didn't bubble correctly.
I've also renamed the existing hooks to match the names used in the specification.
This fixes #2449 and #2367.