SVG Geometry: computed value of properties#14075
Merged
foolip merged 1 commit intoweb-platform-tests:masterfrom Nov 16, 2018
Merged
SVG Geometry: computed value of properties#14075foolip merged 1 commit intoweb-platform-tests:masterfrom
foolip merged 1 commit intoweb-platform-tests:masterfrom
Conversation
dirkschulze
approved these changes
Nov 15, 2018
Contributor
Author
cx cy r rx ry x y computed values are lengths or percentages. https://svgwg.org/svg2-draft/geometry.html
e180e27 to
bb2b9f8
Compare
Member
|
@ewilligers unfortunately yes, you're not the only one affected by this. I've just sent #14096 to make stability jobs on Travis non-blocking until we remove them entirely. I'll admin merge this. |
Contributor
|
test_computed_value("cy", "calc(50% + 60x)"); Is that a typo for 60px? |
Contributor
Author
Yes, sorry. Note that when the test is fixed, Blink fails with
We should also have calc(em - px) tests that results in negatives, so see if r rx ry clamp computed values to 0, while cx cy x y are not clamped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cx cy r rx ry x y computed values are lengths or percentages.