SVG Geometry Properties - parsing#13951
Conversation
|
Builds on #13943 |
dirkschulze
left a comment
There was a problem hiding this comment.
Tests look good. Could we get additional tests for the computed value? auto computes to different things in different properties. Same for geometry properties with percentage values on paint servers.
84764fb to
dae7e78
Compare
|
I will create a separate PR for computed values. |
dae7e78 to
358a814
Compare
The properties cx cy r rx ry x y have the specified initial values, grammar and inheritance behavior. https://svgwg.org/svg2-draft/geometry.html Radii cannot be negative. Unitless lengths are not permitted.
358a814 to
893c920
Compare
|
@foolip Are other tests also having problems? I made irrelevant changes to the test, and the failure persists. It seems Firefox takes 7 minutes, which is OK, but Chrome takes 14 minutes, which is more than 10 minutes:
Should we be adding "travis_wait 30" ? Alternately, can the tests be sharded? |
|
@ewilligers, the stability checks on Travis create rather a lot of trouble and I'd like to disable them sooner rather than later, see #14033. I don't know if it's expected that there's no output at all while this script is running, or if "travis_wait 30" would just lead to it failing in the same way after 30 minutes. For now please just ignore the check, I'll override and admin merge this. |
The properties cx cy r rx ry x y have the specified initial values,
grammar and inheritance behavior.
https://svgwg.org/svg2-draft/geometry.html