Allow stability-checker failures on Travis and report them on Taskcluster#14096
Merged
Allow stability-checker failures on Travis and report them on Taskcluster#14096
Conversation
This was referenced Nov 16, 2018
Member
Author
|
I didn't get the Travis change right, trying again... |
jgraham
approved these changes
Nov 16, 2018
Member
Author
|
Alright, I appear to have succeeded! Review please :) |
Ms2ger
approved these changes
Nov 16, 2018
Contributor
Ms2ger
left a comment
There was a problem hiding this comment.
Please update the commit message and remove the flaky test before landing :)
This reverts commit b74d52c.
Member
Author
|
Alright, merged, I feel like celebrating on such a great Friday. I'll make Taskcluster a required check, that's plenty celebratory. |
This was referenced Nov 16, 2018
This comment has been minimized.
This comment has been minimized.
Contributor
|
Arg, I posted to the wrong thread. My previous message was intended for gh-13194. I'll repost there. Sorry for the confusion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7660.
#13194 remains open to
verify that Taskcluster isn't failing to detect flakiness that Travis
would.