Skip to content

Revert "perf: reuse js dependency"#9389

Merged
JSerFeng merged 1 commit intomainfrom
revert-9352-reuse-js-dep
Feb 19, 2025
Merged

Revert "perf: reuse js dependency"#9389
JSerFeng merged 1 commit intomainfrom
revert-9352-reuse-js-dep

Conversation

@JSerFeng
Copy link
Copy Markdown
Contributor

@JSerFeng JSerFeng commented Feb 19, 2025

Reverts #9352 as it panic in some cases

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 19, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bad2326
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b5a3a6ae4f9e0008c63355

@JSerFeng JSerFeng enabled auto-merge (squash) February 19, 2025 09:29
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 19, 2025
@JSerFeng JSerFeng merged commit 39f13d9 into main Feb 19, 2025
32 of 34 checks passed
@JSerFeng JSerFeng deleted the revert-9352-reuse-js-dep branch February 19, 2025 10:37
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #9389 will degrade performances by 70.32%

Comparing revert-9352-reuse-js-dep (bad2326) with main (3d61889)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 2 regressions
✅ 5 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
Traverse module graph by connections 329.1 µs 361 µs -8.83%
Traverse module graph by dependencies 452.2 µs 1,523.5 µs -70.32%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants