Skip to content

perf: reuse js dependency#9352

Merged
SyMind merged 8 commits intomainfrom
reuse-js-dep
Feb 19, 2025
Merged

perf: reuse js dependency#9352
SyMind merged 8 commits intomainfrom
reuse-js-dep

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Feb 18, 2025

Summary

perf: reuse js dependency

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 18, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 18, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit d76acce
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b519f666da9c0008e2c4d8
😎 Deploy Preview https://deploy-preview-9352--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 18, 2025

CodSpeed Performance Report

Merging #9352 will improve performances by ×3.4

Comparing reuse-js-dep (d76acce) with main (a81bd20)

Summary

⚡ 2 improvements
✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
Traverse module graph by connections 361.1 µs 327.9 µs +10.13%
Traverse module graph by dependencies 1,519.9 µs 450.3 µs ×3.4

@SyMind SyMind merged commit 6032d46 into main Feb 19, 2025
30 checks passed
@SyMind SyMind deleted the reuse-js-dep branch February 19, 2025 03:52
JSerFeng added a commit that referenced this pull request Feb 19, 2025
JSerFeng added a commit that referenced this pull request Feb 19, 2025
Revert "perf: reuse js dependency (#9352)"

This reverts commit 6032d46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants