feat: supports chunkGraph and moduleGraph for cacheGroup.test#9248
Merged
feat: supports chunkGraph and moduleGraph for cacheGroup.test#9248
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #9248 will not alter performanceComparing Summary
|
88533c6 to
c5908fe
Compare
ahabhgk
previously approved these changes
Feb 12, 2025
chenjiahan
reviewed
Feb 12, 2025
chenjiahan
reviewed
Feb 12, 2025
Member
|
The current implementation is not good. In a compilation lifecycle on the JS side, will create multiple moduleGraph and chunkGraph instances. I don't think it's necessary to modify the code on the Rust side, just use the |
b8e5265 to
8c08933
Compare
Contributor
Author
|
Wait for rebase |
5b4ff4b to
d73a4e2
Compare
d73a4e2 to
0467b9b
Compare
SyMind
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #8988
Supports chunkGraph and moduleGraph for
cacheGroup.test, and update documentChecklist