chore(deps): use typescript latest version and "module": "NodeNext"#7211
Closed
SoonIter wants to merge 2 commits intoweb-infra-dev:mainfrom
Closed
chore(deps): use typescript latest version and "module": "NodeNext"#7211SoonIter wants to merge 2 commits intoweb-infra-dev:mainfrom
"module": "NodeNext"#7211SoonIter wants to merge 2 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
ef91db6 to
b7a59b6
Compare
2 tasks
b7a59b6 to
12db4d7
Compare
Member
Author
|
I think it already been fixed |
SoonIter
commented
Jul 19, 2024
chenjiahan
reviewed
Jul 19, 2024
| { | ||
| "compilerOptions": { | ||
| "module": "CommonJS", // DO NOT CHANGE: https://github.com/web-infra-dev/rspack/pull/4650 | ||
| "module": "NodeNext", |
Member
There was a problem hiding this comment.
can you check the output format difference
Member
Author
Member
Author
|
related to #7142, caused by "typescript" phantom dependencies |
hardfist
reviewed
Jul 19, 2024
|
|
||
| ```ts | ||
|
|
||
| /// <reference types="../jest.d.ts" /> |
hardfist
reviewed
Jul 19, 2024
| getPromise() { | ||
| // @ts-expect-error | ||
| const next = i => { | ||
| // @ts-expect-error |
Member
Author
There was a problem hiding this comment.
This line should have reported an error, but it was not reported.
latest typescript fixed this
Member
Author
|
pending with microsoft/TypeScript#59257 |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"module": "NodeNext"tscwhich caused local build failed#4650
#7156
Checklist