Skip to content

Don’t emit __esModule on CJS files that didn’t use ESM syntax#58169

Merged
andrewbranch merged 1 commit intomicrosoft:mainfrom
andrewbranch:bug/58127
Apr 12, 2024
Merged

Don’t emit __esModule on CJS files that didn’t use ESM syntax#58169
andrewbranch merged 1 commit intomicrosoft:mainfrom
andrewbranch:bug/58127

Conversation

@andrewbranch
Copy link
Copy Markdown
Member

Fixes #58127

@andrewbranch andrewbranch requested a review from weswigham April 12, 2024 16:52
@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Apr 12, 2024
@andrewbranch andrewbranch requested a review from jakebailey April 12, 2024 16:52
@andrewbranch andrewbranch merged commit 6431a30 into microsoft:main Apr 12, 2024
@andrewbranch andrewbranch deleted the bug/58127 branch April 12, 2024 19:20
@meros
Copy link
Copy Markdown

meros commented Apr 12, 2024

Thanks man! Didn't expect this to be picked up and fixed so quickly 🙏

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems with __esModule marker in JS/TS mixed node16 environemnt

4 participants