Skip to content

chore(test-tools): fix type issue for benchmark CI#7142

Merged
LingyuCoder merged 1 commit intomainfrom
types_test_tools_0713
Jul 15, 2024
Merged

chore(test-tools): fix type issue for benchmark CI#7142
LingyuCoder merged 1 commit intomainfrom
types_test_tools_0713

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Jul 13, 2024

Summary

Fix the unstable type in test tools, it breaks our benchmark CI:

image

See: https://github.com/web-infra-dev/rspack-ecosystem-benchmark/actions/runs/9916621315/job/27399141909

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 13, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 13, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 98a2d6e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/669275d44f8a5d0008a6354d

@chenjiahan
Copy link
Copy Markdown
Member Author

chenjiahan commented Jul 13, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Jul 13, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-07-12 5086f0e) Current Change
10000_development-mode + exec 2.21 s ± 15 ms 2.23 s ± 26 ms +1.01 %
10000_development-mode_hmr + exec 695 ms ± 2.7 ms 698 ms ± 6.4 ms +0.49 %
10000_production-mode + exec 2.78 s ± 28 ms 2.82 s ± 31 ms +1.40 %
arco-pro_development-mode + exec 1.89 s ± 88 ms 1.89 s ± 102 ms +0.16 %
arco-pro_development-mode_hmr + exec 434 ms ± 0.98 ms 435 ms ± 1.5 ms +0.25 %
arco-pro_production-mode + exec 3.48 s ± 73 ms 3.44 s ± 69 ms -1.23 %
threejs_development-mode_10x + exec 1.61 s ± 12 ms 1.69 s ± 15 ms +4.78 %
threejs_development-mode_10x_hmr + exec 807 ms ± 7.8 ms 862 ms ± 7.2 ms +6.83 %
threejs_production-mode_10x + exec 5.58 s ± 31 ms 5.67 s ± 48 ms +1.72 %

Threshold exceeded: ["threejs_development-mode_10x_hmr + exec"]

@LingyuCoder LingyuCoder merged commit 5657d9b into main Jul 15, 2024
@LingyuCoder LingyuCoder deleted the types_test_tools_0713 branch July 15, 2024 02:23
@SoonIter
Copy link
Copy Markdown
Member

SoonIter commented Jul 15, 2024

why this error only exists on benchmark ci？🤔

@chenjiahan
Copy link
Copy Markdown
Member Author

chenjiahan commented Jul 15, 2024

No idea, I think it should be related to pnpm install

@SoonIter SoonIter mentioned this pull request Jul 19, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@SoonIter SoonIter Awaiting requested review from SoonIter

Assignees

@chenjiahan chenjiahan

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenjiahan @rspack-bot @SoonIter @LingyuCoder