Skip to content

feat: align ExportImportedSpecifierDependency init fragments#4995

Merged
IWANABETHATGUY merged 23 commits intomainfrom
feat/align-init-fragments
Dec 15, 2023
Merged

feat: align ExportImportedSpecifierDependency init fragments#4995
IWANABETHATGUY merged 23 commits intomainfrom
feat/align-init-fragments

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Dec 13, 2023 •
edited by ahabhgk
Loading

Summary

  1. Closed Investigate test failed when enable mangleExports with module federation #4935
  2. Eliminated es globalRuntime in ExportImportedSpecifierDependency
  3. Now the harmonyExportMap is sorted see https://github.com/web-infra-dev/rspack/pull/4995/files#r1427600363

close #4325

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 13, 2023
@IWANABETHATGUY
Copy link
Copy Markdown
Contributor Author

IWANABETHATGUY commented Dec 14, 2023

!canary

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Dec 14, 2023
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2023

0.4.3-canary-f853ea4-20231214144454

@IWANABETHATGUY IWANABETHATGUY changed the title Feat/align init fragments feat: align ExportImportedSpecifierDependency init fragments Dec 14, 2023
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Dec 14, 2023
@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/align-init-fragments branch from 7be0e97 to c5de5f0 Compare December 14, 2023 15:43
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 15, 2023 06:17
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 as a code owner December 15, 2023 06:17
@IWANABETHATGUY IWANABETHATGUY requested review from a team December 15, 2023 06:17
@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/align-init-fragments branch from 673707d to daec8de Compare December 15, 2023 06:17
IWANABETHATGUY
IWANABETHATGUY commented Dec 15, 2023
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Dec 15, 2023
Closed
@IWANABETHATGUY IWANABETHATGUY merged commit 12dbc86 into main Dec 15, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the feat/align-init-fragments branch December 15, 2023 07:04
ahabhgk pushed a commit that referenced this pull request Jan 2, 2024
@IWANABETHATGUY @ahabhgk
feat: align ExportImportedSpecifierDependency init fragments (#4995)
87b5770 
* feat: 🎸 align init fragments

* chore: 🤖 clean

* feat: 🎸 update snapshot

* chore: 🤖 update snapshot

* chore: 🤖 update snapshot

* chore: 🤖 update check.js

* chore: 🤖 update snapshot

* feat: 🎸 sort export map

* chore: 🤖 remove db

g

* chore: 🤖 ck point

* chore: 🤖 ck points

* feat: 🎸 align more condition

* chore: 🤖 normal fragments should not be only

* chore: 🤖 pass all webpack test

* chore: 🤖 recover

* chore: 🤖 recover

* chore: 🤖 lint

* chore: 🤖 recover

* chore: 🤖 update snapshot

* chore: 🤖 update snapshot

* fix: 🐛 typos

* fix: 🐛 fix legacy issues

* chore: 🤖 clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@hyf0 hyf0 Awaiting requested review from hyf0

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate test failed when enable mangleExports with module federation feat: support reexport for cjs-esm interop

2 participants

@IWANABETHATGUY @ahabhgk