Skip to content

fix: loaderContext.importModule should return error#10750

Merged
jerrykingxyz merged 2 commits intoweb-infra-dev:mainfrom
colinaaa:colin/0620/import-module
Jun 23, 2025
Merged

fix: loaderContext.importModule should return error#10750
jerrykingxyz merged 2 commits intoweb-infra-dev:mainfrom
colinaaa:colin/0620/import-module

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

Summary

close: #8536

Related links

Fix the wrong test case introduced by #8590

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jun 20, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 20, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 7f0636e
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68556059d05a530008494a9d

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 20, 2025

CodSpeed Performance Report

Merging #10750 will not alter performance

Comparing colinaaa:colin/0620/import-module (7f0636e) with main (ee7d9bc)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

@colinaaa colinaaa marked this pull request as ready for review June 20, 2025 14:10
@chenjiahan chenjiahan requested a review from jerrykingxyz June 23, 2025 02:44
@jerrykingxyz jerrykingxyz merged commit acedc98 into web-infra-dev:main Jun 23, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: loaderContext.importModule does not return error

2 participants