Skip to content

fix: importModule should have err#8590

Merged
JSerFeng merged 2 commits intomainfrom
fix/import-module-return-err
Dec 3, 2024
Merged

fix: importModule should have err#8590
JSerFeng merged 2 commits intomainfrom
fix/import-module-return-err

Conversation

@JSerFeng
Copy link
Copy Markdown
Contributor

@JSerFeng JSerFeng commented Dec 2, 2024

Summary

close #8536

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 2, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 2, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 541a993
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674ed126cb074d00087f31da

LingyuCoder
LingyuCoder previously approved these changes Dec 3, 2024
@JSerFeng JSerFeng force-pushed the fix/import-module-return-err branch from 25b70f5 to 541a993 Compare December 3, 2024 09:36
@JSerFeng JSerFeng enabled auto-merge (squash) December 3, 2024 09:50
@JSerFeng JSerFeng merged commit 6b0e319 into main Dec 3, 2024
@JSerFeng JSerFeng deleted the fix/import-module-return-err branch December 3, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: loaderContext.importModule does not return error

3 participants