fix: set watchpack limit before loading watchpack#10236
Merged
chenjiahan merged 2 commits intomainfrom Apr 29, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #10236 will not alter performanceComparing 🎉 Hooray!
|
hardfist
approved these changes
Apr 29, 2025
This was referenced May 7, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We tried setting WATCHPACK_WATCHER_LIMIT by default in the Rspack CLI (#5486), but I found that this did not work because watchpack was loaded earlier than the WATCHPACK_WATCHER_LIMIT was set in the Rspack CLI.
This PR fixes the issue by setting WATCHPACK_WATCHER_LIMIT earlier in Rspack core.
Also submitted a PR to the watchpack repo: webpack/watchpack#249, if that gets merged we can remove this.
Checklist