perf: set default WATCHPACK_WATCHER_LIMIT to 20#5486
Merged
Conversation
chenjiahan
approved these changes
Jan 26, 2024
Member
|
Get, I will add this to Rsbuild too. |
2 tasks
This was referenced Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set default WATCHPACK_WATCHER_LIMIT to 20 to improve kill process performance, related to https://github.com/vercel/next.js/pull/51826/files
It takes about 5s+ to kill
rspack devbefore and instantly kill after setWATCHPACK_WATCHER_LIMIT=20in my projectRsbuild seems need this too @chenjiahan
Test Plan
No Need
Require Documentation?