Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the issue related to missing context dependencies by updating both test cases and core logic. The changes include:
- Adding a plugin in the test configuration to assert missing dependencies.
- Updating the test cases to require language-specific modules.
- Modifying the core context module factory logic to include missing dependencies.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/rspack-test-tools/tests/configCases/context/missing-dependency/rspack.config.js | Added a custom plugin to assert that the missing dependency is correctly tracked |
| packages/rspack-test-tools/tests/configCases/context/missing-dependency/index.js | Updated to require language-specific files |
| packages/rspack-test-tools/tests/configCases/context/missing-dependency/errors.js | Added an error expectation for missing dependencies |
| crates/rspack_core/src/context_module_factory.rs | Included missing dependencies in both success and error branches |
Comments suppressed due to low confidence (1)
packages/rspack-test-tools/tests/configCases/context/missing-dependency/rspack.config.js:8
- [nitpick] The plugin name "DonePlugin" is generic; consider renaming it to something more descriptive that reflects its function in handling missing context dependencies.
compiler.hooks.done.tap("DonePlugin", stats => {
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #10221 will not alter performanceComparing 🎉 Hooray!
|
Summary
fix #5536
Removed context directory should be add to missing dependencies of watcher.
Checklist