Skip to content

Revert "refactor: improve render external module for module output"#10126

Merged
chenjiahan merged 1 commit intomainfrom
revert-10080-feat/improve-external-render
Apr 22, 2025
Merged

Revert "refactor: improve render external module for module output"#10126
chenjiahan merged 1 commit intomainfrom
revert-10080-feat/improve-external-render

Conversation

@JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Apr 22, 2025 •
edited
Loading

Reverts #10080

import { v as a } from 'external'

function main(props) {
  const v = 1 // in function scope
  access(a)
}

Webpack only transform names in top level scope, variables that declare in function scope won't be renamed, external module use initFragment to insert new name.

We should figure out another way to implement it

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 22, 2025
@netlify
Copy link

netlify bot commented Apr 22, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c557ab8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680788420047130008c680fc

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 22, 2025

CodSpeed Performance Report

Merging #10126 will not alter performance

Comparing revert-10080-feat/improve-external-render (c557ab8) with main (3a15c54)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan merged commit 51d592e into main Apr 22, 2025
33 of 34 checks passed
@chenjiahan chenjiahan deleted the revert-10080-feat/improve-external-render branch April 22, 2025 13:35
fi3ework added a commit to web-infra-dev/rslib that referenced this pull request Apr 22, 2025
@fi3ework
Revert "chore: bump Rspack to canary (#941)"
62cae41 
This reverts commit 454b6f8.

web-infra-dev/rspack#10126
@fi3ework fi3ework mentioned this pull request Apr 22, 2025
Merged
2 tasks
@Timeless0911 Timeless0911 mentioned this pull request Apr 23, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JSerFeng @chenjiahan