refactor: improve render external module for module output#10080
Merged
refactor: improve render external module for module output#10080
Conversation
✅ Deploy Preview for rspack canceled.
|
5ab41fa to
9d38524
Compare
CodSpeed Performance ReportMerging #10080 will not alter performanceComparing Summary
|
9d38524 to
8a14572
Compare
fi3ework
reviewed
Apr 21, 2025
...k-test-tools/tests/configCases/library/modern-module-named-import-externals/rspack.config.js
Show resolved
Hide resolved
...k-test-tools/tests/configCases/library/modern-module-named-import-externals/rspack.config.js
Show resolved
Hide resolved
Contributor
Member
|
I manually checked test case of Rslib in eco-ci, changes are expected, the output code is much neater. 👍 |
fi3ework
approved these changes
Apr 21, 2025
chenjiahan
pushed a commit
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the rendering of ExternalModule.
Before:
This PR:
Design detail
Add a new concatenation hook named
concatenation_info, this hook is used to let module prepare some data in the correct topological order, for example, moduleA, moduleB can use this hook to add their globally used names.ExternalModule has global names because they will insert some import statements through
InitFragment.Tap this hook, and insert the
ato the globally used names, so we can deconflict the conflict symbol name.Checklist