revert: lightningcss loader error recovery default value#10076
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #10076 will not alter performanceComparing 🎉 Hooray!
|
chenjiahan
reviewed
Apr 18, 2025
Member
There was a problem hiding this comment.
Can you add some documentation to tell (this can be done in another PR):
- The default error recovery behavior of Rspack's lightningcss-loader
- An example for enabling error recovery in lightningcss-loader
- An example for ignore lightningcss warnings using https://rspack.dev/config/other-options#ignorewarnings
chenjiahan
approved these changes
Apr 18, 2025
This was referenced Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert #9979
Related issue: #10056
The syntax validation of lightning CSS is too strict and not user-friendly for Rspack users, so the default value for error recovery revert to true.
But when error recovery is true, the warning will give to the user now.
Checklist