Skip to content

fix: lightningcss loader report error by default#9979

Merged
SyMind merged 1 commit intomainfrom
lightningcss-loader-report-error
Apr 10, 2025
Merged

fix: lightningcss loader report error by default#9979
SyMind merged 1 commit intomainfrom
lightningcss-loader-report-error

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Apr 10, 2025

Summary

When user not set recoverError options for lightningcss loader, should use false by default value.

Close #9896

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Apr 10, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 10, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit c7cf6fb
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67f78ec7181ddd000834dadd
😎 Deploy Preview https://deploy-preview-9979--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SyMind SyMind marked this pull request as ready for review April 10, 2025 09:28
@SyMind SyMind requested a review from JSerFeng as a code owner April 10, 2025 09:28
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 10, 2025

CodSpeed Performance Report

Merging #9979 will not alter performance

Comparing lightningcss-loader-report-error (c7cf6fb) with main (5162020)

Summary

✅ 11 untouched benchmarks

@SyMind SyMind merged commit 8c6c944 into main Apr 10, 2025
35 checks passed
@SyMind SyMind deleted the lightningcss-loader-report-error branch April 10, 2025 09:47
@h-a-n-a h-a-n-a mentioned this pull request Apr 15, 2025
SyMind added a commit that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: pass wrong css to lightingcss-loader without any warning but loader will remove the code

2 participants