chore: merge rust & js loader & CPU Profiling together#10009
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
151b59e to
d2b1569
Compare
d158a2d to
9cbbc69
Compare
hardfist
commented
Apr 16, 2025
hardfist
commented
Apr 16, 2025
hardfist
commented
Apr 16, 2025
CodSpeed Performance ReportMerging #10009 will not alter performanceComparing Summary
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/rspack/src/trace/index.ts:90
- The current naive implementation for merging trace events assumes that the original trace file ends with a ']'. Consider validating the trace structure or adding error handling to ensure the resulting JSON remains valid.
const newTrace = originTrace.replace(/]$/, `${eventMsg}
]`);
e57a906 to
b1155be
Compare
ahabhgk
reviewed
Apr 17, 2025
crates/rspack_plugin_javascript/src/parser_and_generator/mod.rs
Outdated
Show resolved
Hide resolved
4d6d274 to
8c54358
Compare
Co-authored-by: Gengkun <ahabhgk@gmail.com>
8c54358 to
67097fa
Compare
ahabhgk
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is just a POC now but it seems we can take full power of perfetto and see CPU profiler and tracing together, thanks to @LalitMaganti great support for Node.js CPU Profiler in Perfetto in google/perfetto#1267.
It's interesting to see that https://profiler.firefox.com/ also support show CPU profiler and trace together
Follow up
Checklist