tp: fix parsing of Chrome Devtools/NodeJS CPU profiling data#1267
Merged
LalitMaganti merged 1 commit intomainfrom Apr 15, 2025
Merged
tp: fix parsing of Chrome Devtools/NodeJS CPU profiling data#1267LalitMaganti merged 1 commit intomainfrom
LalitMaganti merged 1 commit intomainfrom
Conversation
stevegolton
approved these changes
Apr 14, 2025
Turns out they use a separate format to V8 with a more standardised system [1]. Since supporting it is quite simple, just do it. [1] https://chromedevtools.github.io/devtools-protocol/tot/Profiler/#type-ProfileNode
4d4d00a to
b26f463
Compare
aMayzner
approved these changes
Apr 15, 2025
|
@LalitMaganti sorry to bother, but it seems this only fixes the json_trace_tokenizer and not fixes the track_event_tokenizer, when I try to migrate from json format trace to proto format trace, it seems the track_event tokenizer not support NodeJS style CPU profiling yet. |
Member
Author
|
Unfortunately I don't have any bandwidth to work on this as I'm in the midst of some major projects. Patches welcome if you want to contribute, with the existing code it should be pretty straightforward to see how to do it. |
olehkuznetsov
pushed a commit
to olehkuznetsov/perfetto
that referenced
this pull request
Mar 12, 2026
…1267) Turns out they use a separate format to V8 with a more standardised system [1]. Since supporting it is quite simple, just do it. See discussion at google#275 for what prompted this. [1] https://chromedevtools.github.io/devtools-protocol/tot/Profiler/#type-ProfileNode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out they use a separate format to V8 with a more standardised
system [1]. Since supporting it is quite simple, just do it.
See discussion at #275 for what prompted this.
[1] https://chromedevtools.github.io/devtools-protocol/tot/Profiler/#type-ProfileNode