Conversation
Bumps [github.com/mattn/go-sqlite3](https://github.com/mattn/go-sqlite3) from 1.14.28 to 1.14.34. - [Release notes](https://github.com/mattn/go-sqlite3/releases) - [Commits](mattn/go-sqlite3@v1.14.28...v1.14.34) --- updated-dependencies: - dependency-name: github.com/mattn/go-sqlite3 dependency-version: 1.14.34 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
1cd847e to
9db7b9b
Compare
wcatz
added a commit
that referenced
this pull request
Mar 15, 2026
* feat(approval): deny with instructions + fix CodeQL path injection - Auto-scroll only when user is near bottom of chat (no more yanking back while reading earlier messages during streaming) - Auto-approve toggle: muted when OFF, red glow when ON (YOLO mode) - Fix 3 HIGH CodeQL go/path-injection findings in project/context.go: validate resolved path is existing directory before file operations * fix(security): inline path joins for CodeQL go/path-injection CodeQL cannot trace through safeJoin as a sanitizer. Since all filenames are hardcoded constants and the base path is validated (EvalSymlinks + Stat + IsDir), use filepath.Join directly with nosec annotations. Clears alerts #4-#6.
wcatz
added a commit
that referenced
this pull request
Apr 17, 2026
… hybrid search Addresses 11 of 13 findings from MCP server audit: 🔴 Reds (crashes / data loss): - ghost_health: p.ID[:8] panics on _global (7 chars) → min(len, 8) - ghost_memory_delete: no ownership boundary → requires project_id, verifies via GetByIDs - ghost_task_update: Priority int+omitempty silently clobbers to 0 → *int/*string + fetch current task 🟠 Correctness: - ghost_task_update: omitting description wiped the field → fetch-and-merge via new GetTask store method - ghost_search_all: FTS-only even when embedder available → SearchHybridAll (RRF) added to store - Resource URI handlers: copy-pasted 3×, no PathUnescape → parseProjectIDFromURI helper 🟡 Quality / Design: - EnsureProject path arg was project name, not fs path → pass "" for MCP-created projects - ghost_memory_save / ghost_save_global: no content length limit → 2000-char cap, truncation reported - ghost_task_list: hardcoded limit=30 → configurable Limit field (default 30, max 100) - formatMemories: json.Marshal result silently discarded → check err before use - ghost_memory_search description: category filter truncation undocumented → documented Store additions: GetTask, SearchVectorAll, SearchHybridAll (all wired into MemoryStore interface). Deferred: resolveProjectID O(n) scan (#6), registerTools monolith (#13).
5 tasks
wcatz
added a commit
that referenced
this pull request
Apr 17, 2026
… hybrid search (#146) * fix(mcp): audit fixes — ownership check, panic guard, partial update, hybrid search Addresses 11 of 13 findings from MCP server audit: 🔴 Reds (crashes / data loss): - ghost_health: p.ID[:8] panics on _global (7 chars) → min(len, 8) - ghost_memory_delete: no ownership boundary → requires project_id, verifies via GetByIDs - ghost_task_update: Priority int+omitempty silently clobbers to 0 → *int/*string + fetch current task 🟠 Correctness: - ghost_task_update: omitting description wiped the field → fetch-and-merge via new GetTask store method - ghost_search_all: FTS-only even when embedder available → SearchHybridAll (RRF) added to store - Resource URI handlers: copy-pasted 3×, no PathUnescape → parseProjectIDFromURI helper 🟡 Quality / Design: - EnsureProject path arg was project name, not fs path → pass "" for MCP-created projects - ghost_memory_save / ghost_save_global: no content length limit → 2000-char cap, truncation reported - ghost_task_list: hardcoded limit=30 → configurable Limit field (default 30, max 100) - formatMemories: json.Marshal result silently discarded → check err before use - ghost_memory_search description: category filter truncation undocumented → documented Store additions: GetTask, SearchVectorAll, SearchHybridAll (all wired into MemoryStore interface). Deferred: resolveProjectID O(n) scan (#6), registerTools monolith (#13). * fix(lint): add nolint:errcheck to SearchVectorAll defer rows.Close() * chore(deps): bump google.golang.org/api from 0.272.0 to 0.275.0 (#145) Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.272.0 to 0.275.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.272.0...v0.275.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.275.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/mattn/go-sqlite3 from 1.14.28 to 1.14.34.
Commits
2087331add script to create pull-requesta510883Upgrade SQLite to version 3051002dce6b34Add percentile extension3c885a9Upgrade SQLite to version 30510013e773a9update github workflows2f6a2bbfix upgrade scriptaa7cdd3update upgrade scripta66908ause quote include instead of angled include for sqlite3-binding.h8bf7a8aupdate amalgamation code2e165e0fix syntax errorDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)