fix(reflection): guard against empty-content and dramatic memory reduction#13
Merged
fix(reflection): guard against empty-content and dramatic memory reduction#13
Conversation
…ction Haiku reflection could silently wipe memories in two scenarios: - Returning memories with empty content strings (passes len>0 check) - Returning far fewer memories than exist (catastrophic consolidation) Add empty-content filter (strips blank/whitespace-only memories before processing) and a dramatic reduction guard (blocks replace when new set is less than 50% of existing non-manual memories, threshold >= 6).
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
wcatz
added a commit
that referenced
this pull request
Apr 17, 2026
… hybrid search Addresses 11 of 13 findings from MCP server audit: 🔴 Reds (crashes / data loss): - ghost_health: p.ID[:8] panics on _global (7 chars) → min(len, 8) - ghost_memory_delete: no ownership boundary → requires project_id, verifies via GetByIDs - ghost_task_update: Priority int+omitempty silently clobbers to 0 → *int/*string + fetch current task 🟠 Correctness: - ghost_task_update: omitting description wiped the field → fetch-and-merge via new GetTask store method - ghost_search_all: FTS-only even when embedder available → SearchHybridAll (RRF) added to store - Resource URI handlers: copy-pasted 3×, no PathUnescape → parseProjectIDFromURI helper 🟡 Quality / Design: - EnsureProject path arg was project name, not fs path → pass "" for MCP-created projects - ghost_memory_save / ghost_save_global: no content length limit → 2000-char cap, truncation reported - ghost_task_list: hardcoded limit=30 → configurable Limit field (default 30, max 100) - formatMemories: json.Marshal result silently discarded → check err before use - ghost_memory_search description: category filter truncation undocumented → documented Store additions: GetTask, SearchVectorAll, SearchHybridAll (all wired into MemoryStore interface). Deferred: resolveProjectID O(n) scan (#6), registerTools monolith (#13).
5 tasks
wcatz
added a commit
that referenced
this pull request
Apr 17, 2026
… hybrid search (#146) * fix(mcp): audit fixes — ownership check, panic guard, partial update, hybrid search Addresses 11 of 13 findings from MCP server audit: 🔴 Reds (crashes / data loss): - ghost_health: p.ID[:8] panics on _global (7 chars) → min(len, 8) - ghost_memory_delete: no ownership boundary → requires project_id, verifies via GetByIDs - ghost_task_update: Priority int+omitempty silently clobbers to 0 → *int/*string + fetch current task 🟠 Correctness: - ghost_task_update: omitting description wiped the field → fetch-and-merge via new GetTask store method - ghost_search_all: FTS-only even when embedder available → SearchHybridAll (RRF) added to store - Resource URI handlers: copy-pasted 3×, no PathUnescape → parseProjectIDFromURI helper 🟡 Quality / Design: - EnsureProject path arg was project name, not fs path → pass "" for MCP-created projects - ghost_memory_save / ghost_save_global: no content length limit → 2000-char cap, truncation reported - ghost_task_list: hardcoded limit=30 → configurable Limit field (default 30, max 100) - formatMemories: json.Marshal result silently discarded → check err before use - ghost_memory_search description: category filter truncation undocumented → documented Store additions: GetTask, SearchVectorAll, SearchHybridAll (all wired into MemoryStore interface). Deferred: resolveProjectID O(n) scan (#6), registerTools monolith (#13). * fix(lint): add nolint:errcheck to SearchVectorAll defer rows.Close() * chore(deps): bump google.golang.org/api from 0.272.0 to 0.275.0 (#145) Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.272.0 to 0.275.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.272.0...v0.275.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.275.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReplaceNonManual— previously[{"content":""}]passed thelen > 0check and triggered a full replaceTest plan
go test ./internal/reflection/... -v— all 6 new tests passgo vet ./internal/reflection/...— clean