Merged
Conversation
daxpedda
requested changes
Jun 14, 2023
Contributor
Author
Done :) |
Co-authored-by: daxpedda <daxpedda@gmail.com>
daxpedda
approved these changes
Jun 14, 2023
Member
daxpedda
left a comment
There was a problem hiding this comment.
LGTM!
Thank you for your contribution!
ErichDonGubler
added a commit
to erichdongubler-contrib/wasm-bindgen
that referenced
this pull request
Jan 30, 2024
Retains some workarounds that cause issues with generation: * `GPUPipelineError`'s first argument remains required; see also [`rustwasm/wasm-bindgen`wasm-bindgen#3480](wasm-bindgen#3480). * `[AllowShared] BufferSource data` arguments in `GPUQueue` methods are not yet changed to `AllowSharedBufferSource data`.
ErichDonGubler
added a commit
to erichdongubler-contrib/wasm-bindgen
that referenced
this pull request
Jan 30, 2024
Retains some workarounds that cause issues with generation: * `GPUPipelineError`'s first argument remains required; see also [`rustwasm/wasm-bindgen`wasm-bindgen#3480](wasm-bindgen#3480). * `[AllowShared] BufferSource data` arguments in `GPUQueue` methods are not yet changed to `AllowSharedBufferSource data`.
ErichDonGubler
added a commit
to erichdongubler-contrib/wasm-bindgen
that referenced
this pull request
Jan 30, 2024
Retains some workarounds that cause issues with generation: * `GPUPipelineError`'s first argument remains required; see also [`rustwasm/wasm-bindgen`wasm-bindgen#3480](wasm-bindgen#3480). * `[AllowShared] BufferSource data` arguments in `GPUQueue` methods are not yet changed to `AllowSharedBufferSource data`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated WebGPU's webidl from the current state of the spec.
However, I made one manual change to the IDL:
The constructor of GPUPipelineError has an optional argument followed by a required argument, which webidl can't handle (or is illegal?). As a fix, I made the optional argument (
message) a required one.I think
GPUPipelineErroris not meant to be created by a user, so I'm not sure how big of a deal this is.