Add WebIDLs for experimental AudioContext sinkId, setSinkId#3433
Merged
daxpedda merged 3 commits intowasm-bindgen:mainfrom Jun 13, 2023
tylerbarker:main
Merged
Add WebIDLs for experimental AudioContext sinkId, setSinkId#3433daxpedda merged 3 commits intowasm-bindgen:mainfrom tylerbarker:main
daxpedda merged 3 commits intowasm-bindgen:mainfrom
tylerbarker:main
Conversation
Contributor
Author
|
Okay what I can gather from the failing CI is there's an issue because I mistakenly hard-coded the experimental feature decorators in I can see now they need to be included in the |
Member
|
Yes, you should be able to use Let me know if you encounter any problems. |
daxpedda
requested changes
May 17, 2023
Member
daxpedda
left a comment
There was a problem hiding this comment.
We should implement the rest of the interface too:
AudioSinkInfoAudioSinkOptionsAudioSinkTypeBaseAudioContext.onsinkchangeAudioContextOptions.sinkId
Member
|
To generate the WebIDL correctly you have to run the following: |
daxpedda
requested changes
Jun 12, 2023
* added unstable AudioContext partial with audio sink types * unrelated to sink, but I also added latencyHint to AudioContextOptions as it's stable
Member
|
Thanks @tylerbarker! I just rebased and fixed the changelog. |
JolifantoBambla
pushed a commit
to JolifantoBambla/wasm-bindgen
that referenced
this pull request
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I'm working on some audio stuff and found these features I need were missing - thought it might be useful to contribute? Let me know if I'm missing something or have done this incorrectly. Cheers ✌️