Merged
Conversation
Contributor
Author
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
02d97d0 to
dc72ae3
Compare
12e2d50 to
9af185d
Compare
0f0c7c4 to
9bc395e
Compare
9bc395e to
0bdcc5f
Compare
dmitryduev
reviewed
Nov 19, 2025
dmitryduev
reviewed
Nov 19, 2025
dmitryduev
approved these changes
Nov 19, 2025
432af45 to
9523d09
Compare
Contributor
Author
Merge activity
|
9523d09 to
12d4a7d
Compare
8444cac to
12d4a7d
Compare
12d4a7d to
b4d545e
Compare
This was referenced Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Updates
_loginto make it usable inApi._load_api_keyand fixes a bug in_load_api_key.Pulls out the
_noop,_offlineandwandb.runchecks into the higher levelwandb.login()(which is also called by thewandb loginCLI). The_noopand_offlinechecks are already present inwandb.init()and thewandb.runcheck is not relevant there. The fact thatApi._load_api_keydoesn't work if theidentity_token_filesetting is set is the same as it was before._loginis called bylogin()(which is called by thewandb loginCLI),wandb.init(), Sweeps, and nowApi._load_api_key(). The changes above shouldn't matter for Sweeps.I recently refactored
_load_api_key()to use the newauthmethods in PR #10893 but in doing so introduced a subtle bug: ifApi._load_api_keyprompts for a key, that key is not saved in the session, and later calls toApi()will prompt again. I will add anauthmethod for this soon, but due to other obstacles, using_loginis the cleaner refactoring path.