Skip to content

refactor: define Auth type and core functions#10944

Merged
timoffex merged 1 commit intomainfrom
timoffex/11-19-auth_type
Nov 25, 2025
Merged

refactor: define Auth type and core functions#10944
timoffex merged 1 commit intomainfrom
timoffex/11-19-auth_type

Conversation

@timoffex
Copy link
Copy Markdown
Contributor

@timoffex timoffex commented Nov 20, 2025 •
edited
Loading

Defines the Auth type, the AuthApiKey implementation, and the core session credential management functions.

Also defines the AuthIdentityTokenFile type, although I am not certain about the public interface for it. It's only needed as a bridge between auth and settings for now; the actual logic around JWTs is still elsewhere.

This PR does not export the new types from wandb and does not update old code to use the new functions yet.

This was referenced Nov 20, 2025
Merged
Merged
Merged
Merged
@timoffex Graphite App
Copy link
Copy Markdown
Contributor Author

timoffex commented Nov 20, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@timoffex timoffex mentioned this pull request Nov 20, 2025
Merged
@timoffex timoffex changed the title auth type refactor: define Auth type and core functions Nov 20, 2025
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from 198ec0d to 0e7467e Compare November 20, 2025 02:32
@timoffex timoffex force-pushed the timoffex/11-19-url_validation branch from 50b67d0 to 2f9e532 Compare November 20, 2025 02:32
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from 0e7467e to 3dfd8f8 Compare November 20, 2025 02:35
@timoffex timoffex force-pushed the timoffex/11-19-url_validation branch from 2f9e532 to 1f833cb Compare November 21, 2025 00:55
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from 3dfd8f8 to 9a6704e Compare November 21, 2025 00:55
@timoffex timoffex force-pushed the timoffex/11-19-url_validation branch 2 times, most recently from 6419fc4 to 8b50a92 Compare November 21, 2025 01:05
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from 9a6704e to 4079408 Compare November 21, 2025 01:05
@timoffex timoffex force-pushed the timoffex/11-19-url_validation branch from 8b50a92 to a9be08c Compare November 21, 2025 01:05
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from 4079408 to 662ee58 Compare November 21, 2025 01:05
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.12346% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
wandb/sdk/lib/auth/authenticate.py 84.81% 12 Missing ⚠️
wandb/sdk/lib/auth/wbnetrc.py 80.00% 2 Missing ⚠️
wandb/sdk/lib/auth/auth.py 98.00% 1 Missing ⚠️
wandb/sdk/lib/auth/host_url.py 95.23% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@timoffex timoffex changed the base branch from timoffex/11-19-url_validation to graphite-base/10944 November 21, 2025 01:26
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from 662ee58 to cc7927e Compare November 21, 2025 01:44
@timoffex timoffex force-pushed the graphite-base/10944 branch from a9be08c to 98fd957 Compare November 21, 2025 01:44
@graphite-app graphite-app bot changed the base branch from graphite-base/10944 to main November 21, 2025 01:45
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from cc7927e to 852834b Compare November 21, 2025 01:45
@timoffex timoffex changed the base branch from main to graphite-base/10944 November 24, 2025 23:57
@timoffex timoffex changed the base branch from graphite-base/10944 to main November 24, 2025 23:58
@timoffex timoffex changed the base branch from main to graphite-base/10944 November 24, 2025 23:58
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from 852834b to 62d3551 Compare November 24, 2025 23:59
@timoffex timoffex changed the base branch from graphite-base/10944 to timoffex/11-24-api_oidc November 24, 2025 23:59
@timoffex timoffex marked this pull request as ready for review November 24, 2025 23:59
@timoffex timoffex requested a review from a team as a code owner November 24, 2025 23:59
@timoffex timoffex mentioned this pull request Nov 24, 2025
Merged
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from 62d3551 to ee3fd14 Compare November 25, 2025 00:11
@timoffex timoffex changed the base branch from timoffex/11-24-api_oidc to graphite-base/10944 November 25, 2025 01:16
@timoffex timoffex force-pushed the graphite-base/10944 branch from b7b8860 to 7a611a1 Compare November 25, 2025 01:17
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from ee3fd14 to 3c5bfa7 Compare November 25, 2025 01:17
@graphite-app graphite-app bot changed the base branch from graphite-base/10944 to main November 25, 2025 01:18
@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch 3 times, most recently from 3328981 to 987b7cd Compare November 25, 2025 19:11
dmitryduev
dmitryduev approved these changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@timoffex Graphite App
Copy link
Copy Markdown
Contributor Author

timoffex commented Nov 25, 2025 •
edited
Loading

Merge activity

  • Nov 25, 9:43 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 25, 9:43 PM UTC: Graphite rebased this pull request as part of a merge.
  • Nov 25, 9:54 PM UTC: @timoffex merged this pull request with Graphite.

@timoffex timoffex force-pushed the timoffex/11-19-auth_type branch from 987b7cd to 62379a6 Compare November 25, 2025 21:43
@timoffex timoffex merged commit ee7c44e into main Nov 25, 2025
34 checks passed
@timoffex timoffex deleted the timoffex/11-19-auth_type branch November 25, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitryduev dmitryduev dmitryduev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timoffex @dmitryduev