Conversation
|
@jgraham @gsnedders PTAL. We internally discussed what formats should be considered. I suggested we use the ones proposed here, but @OrKoN questioned whether they are compatible with other browsers. Considering implementations can throw unsupported operation, I think these should be okay. Alternatively, we can make this a string and state it must be a image mime type. This is more flexible in case you folks have other requirements such as proprietary formats. For example, We could then change the algorithm to allow implementation-specific formats when the format is not one of the predefined types (webp, png, and jpeg). |
|
I think if there will be no agreement that we need to support a shared set of the formats, we can probably have a vendor prefixed extension for the screenshot types in chromium-bidi. |
e9b2e36 to
1bbdfb1
Compare
3c8cd2b to
536afce
Compare
536afce to
080ac41
Compare
55d0c6a to
a532870
Compare
1063fae to
430d6a9
Compare
430d6a9 to
cd0805b
Compare
113a35b to
572ce95
Compare
572ce95 to
32b86c5
Compare
jgraham
left a comment
There was a problem hiding this comment.
Just one change required here, I think.
8943139 to
08a647e
Compare
08a647e to
dd89c4a
Compare
|
@gsnedders @jgraham Is it ready to land? |
SHA: 8808a94 Reason: push, by jrandolf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 073f489 Reason: push, by jrandolf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR implements screenshot formats.
Closes #383
FAQ
Do implementations need to support all formats?
No, if the implementation is unable to capture a screenshot of a context for any reason, then return error with error code unsupported operation.
Preview | Diff