[WebDriver BiDi] Add screenshot origin/format tests#42804
Merged
Conversation
This was referenced Oct 27, 2023
OrKoN
reviewed
Oct 27, 2023
ebdb006 to
fd6b01e
Compare
fd6b01e to
c044e0a
Compare
lutien
reviewed
Oct 27, 2023
Contributor
lutien
left a comment
There was a problem hiding this comment.
I see that the target for this PR is another PR and not master, could you maybe change it? It's problematic because the changes from the target PR cause the unit test failures here.
Also, I guess we should test the combination of origin=document and clip, especially interesting would be the case when the target area is outside of viewport. What do you think?
webdriver/tests/bidi/browsing_context/capture_screenshot/invalid.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/browsing_context/capture_screenshot/invalid.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/browsing_context/capture_screenshot/invalid.py
Outdated
Show resolved
Hide resolved
whimboo
reviewed
Oct 27, 2023
webdriver/tests/bidi/browsing_context/capture_screenshot/format.py
Outdated
Show resolved
Hide resolved
0147918 to
8c03723
Compare
d825448 to
d6f4c4d
Compare
8c03723 to
e85f834
Compare
d6f4c4d to
9578b49
Compare
e6cd773 to
2915ebb
Compare
896bb92 to
35849b0
Compare
Contributor
|
@jrandolf mind resolving the conflict for this PR before I do the next review? Tests for |
ef12994 to
aca7be3
Compare
2915ebb to
8f81a79
Compare
Contributor
Author
whimboo
requested changes
Nov 17, 2023
Contributor
whimboo
left a comment
There was a problem hiding this comment.
Some remaining comments. Otherwise it seems to be fine now.
webdriver/tests/bidi/browsing_context/capture_screenshot/clip.py
Outdated
Show resolved
Hide resolved
f1a570a to
9d302f2
Compare
9d302f2 to
4b3b12f
Compare
whimboo
approved these changes
Nov 17, 2023
| def __init__( | ||
| self, element: Mapping[str, Any] | ||
| ): | ||
| def __init__(self, element: Mapping[str, Any]): |
Contributor
There was a problem hiding this comment.
Looks like we missed the call to dict.__init__() here as well, but up to you to fix it now or later.
Contributor
There was a problem hiding this comment.
@jrandolf please follow up on this once you are back
webdriver/tests/bidi/browsing_context/capture_screenshot/__init__.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/browsing_context/capture_screenshot/origin.py
Outdated
Show resolved
Hide resolved
OrKoN
approved these changes
Nov 24, 2023
…n.py Co-authored-by: Henrik Skupin <mail@hskupin.info>
…t__.py Co-authored-by: Henrik Skupin <mail@hskupin.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for w3c/webdriver-bidi#564 and w3c/webdriver-bidi#561