Rename AddressErrorFields -> AddressErrors#755
Merged
marcoscaceres merged 1 commit intogh-pagesfrom Jul 16, 2018
Merged
Conversation
Member
Author
|
@domenic, just a rename here. We already implemented this in Gecko as |
domenic
approved these changes
Jul 16, 2018
Collaborator
domenic
left a comment
There was a problem hiding this comment.
This is editorial, and not detectable, so really Gecko could call this whatever it wants...
Member
Author
Yeah, true that... but it has impact when searching for things in c++ across engines, etc. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 19, 2018
This corresponds to the upstream spec changes on: - w3c/payment-request#745 - w3c/payment-request#755 Bug: 861704 Change-Id: Ib2cac3f3964eb99aa4fea5927f6df9d8b56dee2a Reviewed-on: https://chromium-review.googlesource.com/1142044 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#576653}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following tasks have been completed:
Implementation commitment:
Impact on Payment Handler spec?
Preview | Diff