Drop prefixes, suffixes from error field members#745
Merged
marcoscaceres merged 2 commits intogh-pagesfrom Jul 9, 2018
Merged
Conversation
Member
Author
|
@domenic, we need to keep dictionary PaymentDetailsUpdate : PaymentDetailsBase {
DOMString error;
PaymentItem total;
AddressErrorFields shippingAddressErrors;
};Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1473081 |
Member
Author
|
@domenic, hopefully quick review here. Implementations are underway in Blink and Firefox so if you could spare some cycles 🙏 |
domenic
approved these changes
Jul 9, 2018
| DOMString regionError; | ||
| DOMString regionCodeError; | ||
| DOMString sortingCodeError; | ||
| DOMString addressLine; |
Collaborator
There was a problem hiding this comment.
Unimportant nit: the order here is different than for AddressInit, which is itself different from PaymentAddress. shrug
Member
Author
There was a problem hiding this comment.
Gonna go through the spec after all these parts land and put things in order. Right now just want to get things tested and implemented.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 19, 2018
This corresponds to the upstream spec changes on: - w3c/payment-request#745 - w3c/payment-request#755 Bug: 861704 Change-Id: Ib2cac3f3964eb99aa4fea5927f6df9d8b56dee2a Reviewed-on: https://chromium-review.googlesource.com/1142044 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#576653}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #736
The following tasks have been completed:
Implementation commitment:
Impact on Payment Handler spec?
Preview | Diff