Merged
Conversation
altafan
added a commit
that referenced
this pull request
Jan 30, 2024
* Add internal support for schnorr signing * Update deps * Update protos and interface layer * Fixes after review * Fixes (#2) * pair programming fixes * fix prevouts assets, values and scripts * Fixes * Update deps * Fixes * Update deps --------- Co-authored-by: Louis Singer <41042567+louisinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds api spec of the wallet daemon.
Purpose of a daemon is to run as a sidecar for other applications and removes 'heavy burden' of maintaining internal wallet.
Protobuf files are splitted into 4 files that I see as main features of the wallet.
Wallet -> covers creation/restore of wallet
Account -> covers creation on addresses, tracking balance and uspents for specific account
Transaction -> used for crafting various types of transactions
Notification -> defines rpc's that are to be used for fetching notification.
This PR contains changes compared to PR#1 related to comments.
Needed to fork again repo cause repo's name changed in the meantime.
PR #1 should be closed.
@tiero @altafan please review.