Add low level rpc to sign taproot inputs #61
Merged
altafan merged 11 commits intovulpemventures:masterfrom Jan 30, 2024
Merged
Conversation
Member
|
I would add a test to serve as reference/example on how to use the API |
louisinger
suggested changes
Dec 15, 2023
louisinger
approved these changes
Dec 18, 2023
louisinger
reviewed
Dec 19, 2023
| value, _ := elementsutil.ValueToBytes(input.ExplicitValue) | ||
| prevoutValues := [][]byte{value} | ||
|
|
||
| hashForSignature := unsignedTx.HashForWitnessV1( |
Contributor
There was a problem hiding this comment.
prevoutScripts, prevoutAssets & prevoutValues must include all the transaction inputs data (not only the signed one)
Contributor
There was a problem hiding this comment.
also, EplicitAsset & ExplicitValue can't be used. The witness utxo data must be used, see the changes there: altafan#2
louisinger
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a low level rpc
SignPsetWithSchnorrKeythat accepts and signs a partial tx.This pset must contain the account(s) xpub as global field and each taproot input to be signed must specify a TapBip32Derivation field.
Internally, the app service retrieves the account index for a global xpub and contrcuts the derivation path required by the signing wallet to generate the correct private key.
Please @louisinger review.