infra: enable tracing-level logging#1815
Conversation
The previous work on this made it *possible*, this actually *uses* that new possibility. There is only a single tracing message at present, used to indicate that tracing itself is turned on, but we can use it for any future debugging work.
24ef9ec to
ca5f245
Compare
| headers = "0.4" | ||
| thiserror = "1.0.16" | ||
| attohttpc = { version = "0.28", default-features = false, features = ["json", "compress", "tls-rustls-native-roots"] } | ||
| log = { version = "0.4", features = ["std"] } No newline at end of file |
There was a problem hiding this comment.
I included this here originally as part of the debugging work in #1784, but it seems reasonable to just have it here regardless. It would also be good to update these kinds of dependencies to be log.workspace = true instead of specifying their own dependencies, but that’s for a different change!
There was a problem hiding this comment.
Seems reasonable! I agree it's worth updating our use of Cargo workspaces—I think this repo pre-dates a lot of the improvements in that space that Cargo has shipped—but also agree it's for a separate PR and not a blocker for anything.
| headers = "0.4" | ||
| thiserror = "1.0.16" | ||
| attohttpc = { version = "0.28", default-features = false, features = ["json", "compress", "tls-rustls-native-roots"] } | ||
| log = { version = "0.4", features = ["std"] } No newline at end of file |
There was a problem hiding this comment.
Seems reasonable! I agree it's worth updating our use of Cargo workspaces—I think this repo pre-dates a lot of the improvements in that space that Cargo has shipped—but also agree it's for a separate PR and not a blocker for anything.
The previous work on this in #1793 made it possible to use more log levels; this actually uses that new possibility. There is only a single tracing message at present, used to indicate that tracing itself is turned on, but we can use it for any future debugging work. Extracted from #1784, where we used it to help diagnose the issues underlying #1744.