Update logger config to support all internal crates#1793
Merged
chriskrycho merged 1 commit intomainfrom Jul 13, 2024
Merged
Conversation
charlespierce
approved these changes
Jul 12, 2024
This was referenced Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while debugging #1784: we assume a prefix of
"volta"for all the crates in the repo, but that is simply not reflective of reality!This raises the question of whether we want to standardize on that (which I think would be fine and dandy) or whether we want to collapse some of these smaller crates together, seeing as they are fairly stable and shouldn’t particularly affect our build times (which I also think would be fine and dandy), but I think we can defer those for later.