fix(vlm): pass thinking flag to dashscope openai backend#939
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Mar 25, 2026
Merged
fix(vlm): pass thinking flag to dashscope openai backend#939qin-ctx merged 1 commit intovolcengine:mainfrom
qin-ctx merged 1 commit intovolcengine:mainfrom
Conversation
|
wangruotian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Failed to generate code suggestions for PR |
qin-ctx
approved these changes
Mar 25, 2026
3 tasks
deepakdevp
added a commit
to deepakdevp/OpenViking
that referenced
this pull request
Mar 25, 2026
Follow-up to volcengine#939 (which fixed OpenAI backends). The LiteLLM backend now sends enable_thinking via extra_body only when the detected provider is DashScope. Non-DashScope providers (OpenAI, Azure, Ollama) never receive this vendor-specific field. Fixes volcengine#923.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the OpenAI-compatible VLM backend so the
thinkingflag is propagated to DashScope-compatible endpoints viaextra_body.enable_thinking.The change is scoped to DashScope detection only, so official OpenAI and Azure requests keep their existing behavior.
Related Issue
Fixes #923
Type of Change
Changes Made
api_basehost.extra_body={"enable_thinking": <bool>}through all four OpenAI VLM completion paths.Testing
Validated with:
python3 -m py_compile openviking/models/vlm/backends/openai_vlm.py tests/unit/test_extra_headers_vlm.pyChecklist
Screenshots (if applicable)
N/A