fix(vlm): scope LiteLLM thinking param to DashScope providers only#958
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Mar 26, 2026
Merged
Conversation
Follow-up to volcengine#939 (which fixed OpenAI backends). The LiteLLM backend now sends enable_thinking via extra_body only when the detected provider is DashScope. Non-DashScope providers (OpenAI, Azure, Ollama) never receive this vendor-specific field. Fixes volcengine#923.
|
Failed to generate code suggestions for PR |
qin-ctx
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #939 (which fixed OpenAI backends). This PR narrows the LiteLLM thinking parameter to DashScope providers only:
_build_kwargs()now detects the provider viaself._detected_providerordetect_provider_by_model(model)and only setsextra_body["enable_thinking"]when provider is"dashscope"Addresses feedback from closed PR #949. Fixes #923.
Test plan
pytest tests/unit/test_vlm_thinking_param.py)enable_thinkingin extra_bodyenable_thinking